[PATCH] D48832: [ARM] ARMCodeGenPrepare backend pass

Sam Parker via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 16 05:59:07 PDT 2018


samparker updated this revision to Diff 155655.
samparker added a comment.

Hi Sjoerd,

Hopefully the changes address the two problems that you found. I still need to write a couple of other tests to convince myself there isn't still an issue similar the one you reported with the aborted compilation.

Most of the changes are code movement, the functional changes are that I now handle negative immediates in all cases, not just the special cased icmp. The mutation of 'roots' has also been tweaked to fix the other issue.

cheers,


https://reviews.llvm.org/D48832

Files:
  lib/Target/ARM/ARM.h
  lib/Target/ARM/ARMCodeGenPrepare.cpp
  lib/Target/ARM/ARMTargetMachine.cpp
  lib/Target/ARM/CMakeLists.txt
  test/CodeGen/ARM/arm-cgp-icmps.ll
  test/CodeGen/ARM/arm-cgp-phis-calls-ret.ll
  test/CodeGen/ARM/arm-cgp-signed.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D48832.155655.patch
Type: text/x-patch
Size: 41742 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180716/03762433/attachment-0001.bin>


More information about the llvm-commits mailing list