[PATCH] D49337: Skip debuginfo intrinsic in markLiveBlocks.

[Hal Finkel via Phabricator via llvm-commits]

hfinkel added inline comments.


================
Comment at: lib/Transforms/Utils/Local.cpp:2025
+          // Skip debug info intrinsics.
+          if (IntrinsicID == Intrinsic::dbg_addr ||
+              IntrinsicID == Intrinsic::dbg_value ||
----------------
You shouldn't need to check for the debugging intrinsics at all. We're skipping all intrinsics except for assume and experimental_guard.


================
Comment at: lib/Transforms/Utils/Local.cpp:2043
+
+          if (IntrinsicID == Intrinsic::experimental_guard) {
+            // A call to the guard intrinsic bails out of the current
----------------
This can be `else if`.


================
Comment at: lib/Transforms/Utils/Local.cpp:2063
 
-      if (auto *CI = dyn_cast<CallInst>(&I)) {
-        Value *Callee = CI->getCalledValue();
         if ((isa<ConstantPointerNull>(Callee) &&
              !NullPointerIsDefined(CI->getFunction())) ||
----------------
This can be `else if` too (if Callee is a Function, then it's not a null pointer constant.


Repository:
  rL LLVM

https://reviews.llvm.org/D49337