[PATCH] D49339: [test-suite] Added Image Processing Kernels Using Benchmark Library: utilities functions

[Dean Michael Berris via Phabricator via llvm-commits]

dberris added a comment.

I'm not sure why these utilities are being added, is there some other patch that will be using this?



================
Comment at: MicroBenchmarks/ImageProcessing/utils/ImageHelper.cpp:34
+        outfile << 255 << " ";
+        ;
+      } else if (image[i * width + j] < 0) {
----------------
Extraneous semicolon, here and below.


================
Comment at: MicroBenchmarks/ImageProcessing/utils/ImageHelper.h:13
+void initializeRandomColouredImage(int *image, int height, int width);
+void saveImage(int *image, char *outputFile, int height, int width);
+
----------------
`const char*` instead for `outputFile`?


================
Comment at: MicroBenchmarks/ImageProcessing/utils/glibc_compat_rand.cpp:12-19
+/**
+ * This rand implementation is designed to emulate the implementation of
+ * rand/srand in recent versions of glibc. This is used for programs which
+ * require this specific rand implementation in order to pass verification
+ * tests.
+ *
+ * For more information, see: http://www.mathstat.dal.ca/~selinger/random/
----------------
Can you update the commit message to include this explanation on why the `glibc_compat_rand.{h,cpp}` files are needed?


Repository:
  rT test-suite

https://reviews.llvm.org/D49339