[PATCH] D49353: [RegAlloc] Skip global splitting if the live range is huge and its spill is trivially rematerializable

Chandler Carruth via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jul 15 16:36:50 PDT 2018


chandlerc added a comment.

Given that this only kicks in towards an edge case, I think this is fine to go on into the tree. It solves a very real problem for us, and we can iterate on it with upstream if there are subsequent comments.

For context of others, this fixes an issue we've hit with flex generated code combined with `-fno-jump-tables`. Sadly, we're using that option a lot more now due to retpolines needing it. This means we end up hitting some weird edge cases like this.


Repository:
  rL LLVM

https://reviews.llvm.org/D49353





More information about the llvm-commits mailing list