[PATCH] D49266: [X86][AArch64][DAGCombine] Unfold 'check for [no] signed truncation' pattern

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added a comment.

In https://reviews.llvm.org/D49266#1162892, @spatel wrote:

> Just a few nits - otherwise, LGTM.


Thank you for the review!



================
Comment at: lib/Target/X86/X86ISelLowering.cpp:4801-4802
 
+bool X86TargetLowering::shouldTransformSignedTruncationCheck(
+    EVT XVT, unsigned KeptBits) const {
+  // For vectors, we don't have a preference..
----------------
spatel wrote:
> Any reason this is in the header file for AArch but in the cpp file for x86?
That seems to be the way the other hooks are defined - in source for X86, in header for aarch64.
What is the preferred way? In headers?


Repository:
  rL LLVM

https://reviews.llvm.org/D49266