[PATCH] D49295: [MachineOutliner] Check the last instruction from the sequence when updating liveness

Francis Visoiu Mistrih via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jul 14 02:45:04 PDT 2018


This revision was automatically updated to reflect the committed changes.
Closed by commit rL337090: [MachineOutliner] Check the last instruction from the sequence when updating… (authored by thegameg, committed by ).

Changed prior to commit:
  https://reviews.llvm.org/D49295?vs=155385&id=155556#toc

Repository:
  rL LLVM

https://reviews.llvm.org/D49295

Files:
  llvm/trunk/lib/CodeGen/MachineOutliner.cpp
  llvm/trunk/test/CodeGen/X86/machine-outliner-disubprogram.ll


Index: llvm/trunk/test/CodeGen/X86/machine-outliner-disubprogram.ll
===================================================================
--- llvm/trunk/test/CodeGen/X86/machine-outliner-disubprogram.ll
+++ llvm/trunk/test/CodeGen/X86/machine-outliner-disubprogram.ll
@@ -2,7 +2,7 @@
 ; that we correctly emit DISubprograms for those functions.
 ; Also make sure that the DISubprograms reference the generated unit.
 ; make sure that if there are two outlined functions in the program, 
-; RUN: llc %s -enable-machine-outliner -mtriple=x86_64-apple-darwin -o /dev/null -print-after=machine-outliner
+; RUN: llc %s -verify-machineinstrs -enable-machine-outliner -mtriple=x86_64-apple-darwin -o /dev/null -print-after=machine-outliner
 define void @f6() #0 !dbg !8 {
 entry:
   %dog = alloca i32, align 4
Index: llvm/trunk/lib/CodeGen/MachineOutliner.cpp
===================================================================
--- llvm/trunk/lib/CodeGen/MachineOutliner.cpp
+++ llvm/trunk/lib/CodeGen/MachineOutliner.cpp
@@ -1309,7 +1309,7 @@
       // First inst in outlined range <-- Anything that's defined in this
       // ...                           .. range has to be added as an implicit
       // Last inst in outlined range  <-- def to the call instruction.
-      std::for_each(CallInst, EndIt, CopyDefs);
+      std::for_each(CallInst, std::next(EndIt), CopyDefs);
     }
 
     // Erase from the point after where the call was inserted up to, and


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D49295.155556.patch
Type: text/x-patch
Size: 1454 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180714/64942fbb/attachment.bin>


More information about the llvm-commits mailing list