[llvm] r337077 - [llvm-mca] Remove unused InstRef formal from pre and post execute callbacks. NFC.

Matt Davis via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 13 17:10:42 PDT 2018


Author: mattd
Date: Fri Jul 13 17:10:42 2018
New Revision: 337077

URL: http://llvm.org/viewvc/llvm-project?rev=337077&view=rev
Log:
[llvm-mca] Remove unused InstRef formal from pre and post execute callbacks. NFC.

Modified:
    llvm/trunk/tools/llvm-mca/FetchStage.cpp
    llvm/trunk/tools/llvm-mca/FetchStage.h
    llvm/trunk/tools/llvm-mca/Pipeline.cpp
    llvm/trunk/tools/llvm-mca/Pipeline.h
    llvm/trunk/tools/llvm-mca/Stage.h

Modified: llvm/trunk/tools/llvm-mca/FetchStage.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-mca/FetchStage.cpp?rev=337077&r1=337076&r2=337077&view=diff
==============================================================================
--- llvm/trunk/tools/llvm-mca/FetchStage.cpp (original)
+++ llvm/trunk/tools/llvm-mca/FetchStage.cpp Fri Jul 13 17:10:42 2018
@@ -29,7 +29,7 @@ bool FetchStage::execute(InstRef &IR) {
   return true;
 }
 
-void FetchStage::postExecute(const InstRef &IR) { SM.updateNext(); }
+void FetchStage::postExecute() { SM.updateNext(); }
 
 void FetchStage::cycleEnd() {
   // Find the first instruction which hasn't been retired.

Modified: llvm/trunk/tools/llvm-mca/FetchStage.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-mca/FetchStage.h?rev=337077&r1=337076&r2=337077&view=diff
==============================================================================
--- llvm/trunk/tools/llvm-mca/FetchStage.h (original)
+++ llvm/trunk/tools/llvm-mca/FetchStage.h Fri Jul 13 17:10:42 2018
@@ -36,7 +36,7 @@ public:
 
   bool hasWorkToComplete() const override final;
   bool execute(InstRef &IR) override final;
-  void postExecute(const InstRef &IR) override final;
+  void postExecute() override final;
   void cycleEnd() override final;
 };
 

Modified: llvm/trunk/tools/llvm-mca/Pipeline.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-mca/Pipeline.cpp?rev=337077&r1=337076&r2=337077&view=diff
==============================================================================
--- llvm/trunk/tools/llvm-mca/Pipeline.cpp (original)
+++ llvm/trunk/tools/llvm-mca/Pipeline.cpp Fri Jul 13 17:10:42 2018
@@ -47,14 +47,14 @@ bool Pipeline::executeStages(InstRef &IR
   return true;
 }
 
-void Pipeline::preExecuteStages(const InstRef &IR) {
+void Pipeline::preExecuteStages() {
   for (const std::unique_ptr<Stage> &S : Stages)
-    S->preExecute(IR);
+    S->preExecute();
 }
 
-void Pipeline::postExecuteStages(const InstRef &IR) {
+void Pipeline::postExecuteStages() {
   for (const std::unique_ptr<Stage> &S : Stages)
-    S->postExecute(IR);
+    S->postExecute();
 }
 
 void Pipeline::run() {
@@ -75,10 +75,10 @@ void Pipeline::runCycle() {
   // Continue executing this cycle until any stage claims it cannot make
   // progress.
   while (true) {
-    preExecuteStages(IR);
+    preExecuteStages();
     if (!executeStages(IR))
       break;
-    postExecuteStages(IR);
+    postExecuteStages();
   }
 
   for (auto &S : Stages)

Modified: llvm/trunk/tools/llvm-mca/Pipeline.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-mca/Pipeline.h?rev=337077&r1=337076&r2=337077&view=diff
==============================================================================
--- llvm/trunk/tools/llvm-mca/Pipeline.h (original)
+++ llvm/trunk/tools/llvm-mca/Pipeline.h Fri Jul 13 17:10:42 2018
@@ -59,9 +59,9 @@ class Pipeline {
   std::set<HWEventListener *> Listeners;
   unsigned Cycles;
 
-  void preExecuteStages(const InstRef &IR);
+  void preExecuteStages();
   bool executeStages(InstRef &IR);
-  void postExecuteStages(const InstRef &IR);
+  void postExecuteStages();
   void runCycle();
 
   bool hasWorkToProcess();

Modified: llvm/trunk/tools/llvm-mca/Stage.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-mca/Stage.h?rev=337077&r1=337076&r2=337077&view=diff
==============================================================================
--- llvm/trunk/tools/llvm-mca/Stage.h (original)
+++ llvm/trunk/tools/llvm-mca/Stage.h Fri Jul 13 17:10:42 2018
@@ -50,12 +50,12 @@ public:
 
   /// Called prior to executing the list of stages.
   /// This can be called multiple times per cycle.
-  virtual void preExecute(const InstRef &IR) {}
+  virtual void preExecute() {}
 
   /// Called as a cleanup and finalization phase after each execution.
   /// This will only be called if all stages return a success from their
   /// execute callback.  This can be called multiple times per cycle.
-  virtual void postExecute(const InstRef &IR) {}
+  virtual void postExecute() {}
 
   /// The primary action that this stage performs.
   /// Returning false prevents successor stages from having their 'execute'




More information about the llvm-commits mailing list