[PATCH] D49144: [FunctionAttrs] Infer the speculatable attribute

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 13 14:12:06 PDT 2018


efriedma added inline comments.


================
Comment at: lib/Transforms/IPO/FunctionAttrs.cpp:1251
+  // have local metadata that might prove the constraint but can't be
+  // speculated).
+
----------------
Do we also need to look for other attributes on the function?  For example, a function which reads memory but is marked readnone, or a function which calls itself but is marked norecurse.


https://reviews.llvm.org/D49144





More information about the llvm-commits mailing list