[PATCH] D49262: [DAGCombiner] Call SimplifyDemandedVectorElts from EXTRACT_VECTOR_ELT

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 13 13:56:08 PDT 2018


efriedma added a comment.

You need to get reviewers for the test changes to AMDGPU and SystemZ.  Otherwise LGTM.



================
Comment at: test/CodeGen/X86/oddshuffles.ll:366
+; SSE2-NEXT:    pshufd {{.*#+}} xmm0 = xmm0[1,1,2,3]
+; SSE2-NEXT:    punpckldq {{.*#+}} xmm0 = xmm0[0],xmm2[0],xmm0[1],xmm2[1]
 ; SSE2-NEXT:    movd %xmm1, 24(%rdi)
----------------
It looks like the total instructions is increasing here?  Maybe an issue with x86 shuffle lowering?


Repository:
  rL LLVM

https://reviews.llvm.org/D49262





More information about the llvm-commits mailing list