[PATCH] D49280: [X86] Remove isel patterns for MOVSS/MOVSD ISD opcodes with integer types.

David Greene via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 13 08:08:08 PDT 2018


greened added inline comments.


================
Comment at: lib/Target/X86/X86ISelLowering.cpp:30736
-    // easier to combine shuffles later on. We've already accounted for the
-    // domain switching cost when we decided to lower with it.
-    bool isFloat = VT.isFloatingPoint();
----------------
It would be worth replicating this comment somewhere, wherever this decision is made, I suppose.  It's helpful to know when such things are intentional.


Repository:
  rL LLVM

https://reviews.llvm.org/D49280





More information about the llvm-commits mailing list