[PATCH] D48816: [VPlan] Introduce VPLoopInfo analysis.

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 13 06:43:28 PDT 2018


fhahn added inline comments.


================
Comment at: lib/Transforms/Vectorize/VPlan.h:1123
+  /// Holds the VPLoopInfo analysis for this VPlan.
+  VPLoopInfo *VPLInfo = nullptr;
+
----------------
Could the VPlan just store a VPLoopInfo object instead of using a raw pointer? 

It would have the advantage of not needing dynamic memory management and it would be clear that each VPlan owns its VPLoopInfo. Instead having setVPLoopInfo we would have something like `analyze()` which would compute the DT and LoopInfo.


https://reviews.llvm.org/D48816





More information about the llvm-commits mailing list