[PATCH] D49279: Allow SyntheticChildFrontEnd's to request that they always get an object, nor a reference or pointer
Jonas Devlieghere via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jul 13 03:28:59 PDT 2018
JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.
LGTM with a nit for the test function name. Thanks Jim!
================
Comment at: packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/multiset/TestDataFormatterLibcxxMultiSet.py:30
+ def check_ii(self, var_name):
+ self.expect(
----------------
Should we call this check_bitset? I had no idea what the `ii` here meant until I found the call that checks the variable with the same name. (and later we call it for a different variable names for the ref/ptr case.
Repository:
rL LLVM
https://reviews.llvm.org/D49279
More information about the llvm-commits
mailing list