[PATCH] D44824: [Spectre] Introduce a new pass to do speculative load hardening to mitigate Spectre variant #1 for x86.

[Eric Christopher via Phabricator via llvm-commits]

echristo added inline comments.


================
Comment at: llvm/lib/Target/X86/X86SpeculativeLoadHardening.cpp:771
+///
+/// FIXME: This should become part of our instruction tables.
+static bool isDataInvariantLoad(MachineInstr &MI) {
----------------
As an addendum after I saw Craig's comments - I definitely agree and think that making this part of the instruction tables is going to be important. That said, conservatively correct here is probably the best direction for now.


Repository:
  rL LLVM

https://reviews.llvm.org/D44824