[PATCH] D49220: [x86] Teach the EFLAGS copy lowering to handle much more complex control flow patterns including forks, merges, and even cyles.

[Chandler Carruth via Phabricator via llvm-commits]

chandlerc added a comment.

All done.



================
Comment at: llvm/test/CodeGen/X86/flags-copy-lowering.mir:777
+# We set EFLAGS in bb.0, clobber them in bb.3, and copy them in bb.2 and bb.6.
+# Because of the cycles this requires hoisting the tests for the bb.6 copy to
+# bb.1 but not using them in bb.2, instead doing local tests within bb.2.
----------------
craig.topper wrote:
> I don't think understand this sentence. I don't see any tests in bb.1 in the CHECKs.
Sorry, "tests" -> the `SETcc` instructions to capture the flag value into a register. Updated this comment text to make more sense.

Also, this comment wasn't actually accurate. Updated it to actually reflect what the CFG was testing. Sorry for the confusion.


Repository:
  rL LLVM

https://reviews.llvm.org/D49220