[PATCH] D49250: [llvm-mca] Add cycleBegin/cycleEnd callbacks to mca::Stage.

Matt Davis via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 12 15:26:55 PDT 2018


mattd marked 2 inline comments as done.
mattd added a comment.

Thanks for the review @andreadb!  I'm totally fine with removing the Cycle formal.  I added it because I thought that some user-defined Stage might find that data useful.  Likewise, the pre/postExecute callbacks take InstRef references, but no existing function makes use of that either.  I'd be happy to remove that InstRef formal as a NFC in another patch.


https://reviews.llvm.org/D49250





More information about the llvm-commits mailing list