[PATCH] D49242: [Intrinsics] define funnel shift IR intrinsics + DAG builder support

[Fabian Giesen via Phabricator via llvm-commits]

fabiang added inline comments.


================
Comment at: docs/LangRef.rst:11903
+The '``llvm.fshl``' family of intrinsic functions performs a funnel shift left:
+two values are concatenated, the combined value is shifted left, and the most
+significant bits are extracted to produce a result that is the same size as the
----------------
"Concatenated" is ambiguous, it should say explicitly which of %a or %b is the low (less significant) half and which is the high half. (From the example, looks like %a is more, %b is less significant.)


================
Comment at: docs/LangRef.rst:11947
+The '``llvm.fshr``' family of intrinsic functions performs a funnel shift right:
+two values are concatenated, the combined value is shifted right, and the least
+significant bits are extracted to produce a result that is the same size as the
----------------
Clarify concatenation here too. (Looks like in this one, %a is low and %b is high.)


https://reviews.llvm.org/D49242