[PATCH] D48670: [ThinLTO] Ensure we always select the same function copy to import
David Li via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jul 12 11:46:29 PDT 2018
davidxl added inline comments.
================
Comment at: include/llvm/Transforms/IPO/FunctionImport.h:36
public:
/// Set of functions to import from a source module. Each entry is a map
/// containing all the functions to import for a source module.
----------------
Nit: fix stale comment. It is not a map any more.
================
Comment at: include/llvm/Transforms/IPO/FunctionImport.h:43
+ /// consisting of the largest threshold applied when deciding whether to
+ /// import it and, if we decided to import, a pointer to the summary instance
+ /// imported.
----------------
maybe make it clearer that when it is rejected for importing, the summary field is nullptr.
================
Comment at: test/Transforms/FunctionImport/funcimport_resolved.ll:32
+; INSTLIM8: Is importing function {{.*}} foo from {{.*}}funcimport_resolved1.ll
+; INSTLIM8: Is importing function {{.*}} linkonceodrfunc from {{.*}}funcimport_resolved1.ll
+; INSTLIM8: Not importing function {{.*}} linkonceodrfunc2 from {{.*}}funcimport_resolved1.ll
----------------
Is or Not importing here?
Repository:
rL LLVM
https://reviews.llvm.org/D48670
More information about the llvm-commits
mailing list