[PATCH] D49198: [scudo] Use -Wl,-z,global on Android

[Evgenii Stepanov via Phabricator via llvm-commits]

eugenis added inline comments.


================
Comment at: lib/scudo/CMakeLists.txt:24
+  if (COMPILER_RT_HAS_Z_GLOBAL)
+    list(APPEND ASAN_DYNAMIC_LINK_FLAGS -Wl,-z,global)
+  endif()
----------------
cryptoad wrote:
> eugenis wrote:
> > ASAN_DYNAMIC_LINK_FLAGS <- is this a typo?
> > 
> > Can this be done in a common code for all sanitizers that intercept malloc?
> > 
> > Also, I don't think github is the canonical source for AOSP, could you update the link in the patch description to https://android.googlesource.com/platform/bionic/+/master/android-changes-for-ndk-developers.md ?
> Doh! Thanks for catching the error.
> Name updated, description updated.
> Regarding the last point, you'd want an update to `SANITIZER_COMMON_LINK_FLAGS` based on interception? (not sure if it's possible, just trying to clarify).
SANITIZER_COMMON_LINK_FLAGS can't depend on interception, I think.

In fact, adding -z,global unconditionally should not break anything as far as I can see.
Could you move this code to the top-level (compiler-rt) CMakeLists, and remove it from asan and hwasan?


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D49198