[PATCH] D47652: [LowerTypeTests] Limit when icall jumptable entries are emitted

[Peter Collingbourne via Phabricator via llvm-commits]

pcc accepted this revision.
pcc added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lib/Transforms/IPO/LowerTypeTests.cpp:1715
+              if (GVS->isLive())
+                External |= GVS->linkage() == GlobalValue::ExternalLinkage;
+
----------------
vlad.tsyrklevich wrote:
> pcc wrote:
> > Wouldn't this apply not just to ExternalLinkage but to other non-local linkages?
> You're right, I care that they're not exported, not that they're not external specifically.
I might write this a little more straightforwardly as
```
if (GVS->isLive() && !GlobalValue::isLocalLinkage(GVS->linkage()))
  Exported = true;
```


Repository:
  rL LLVM

https://reviews.llvm.org/D47652