[PATCH] D48899: [dsymutil] Convert recursion in lookForDIEsToKeep into worklist.

Jonas Devlieghere via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 12 11:06:52 PDT 2018


JDevlieghere added a comment.

I ran the latest version of this patch on clang.  Performance-wise this is the best I could do, which is a  4.32% regression with byte-identical output.

Worklist
--------

md5 hash: f6679a4f5fa759a1d3f1a4595b9945ef

| run | real  | user   | sys  |
| --- | ----- | ------ | ---- |
| 1   | 80.64 | 129.78 | 8.11 |
| 2   | 80.83 | 129.81 | 8.12 |
| 3   | 80.86 | 129.58 | 8.18 |
| 4   | 80.70 | 129.60 | 8.05 |
| 5   | 81.20 | 129.96 | 8.24 |
| AVG | 80.85 | 129.75 | 8.14 |
|



Recursion
---------

md5 hash: f6679a4f5fa759a1d3f1a4595b9945ef

| run | real  | user   | sys  |
| --- | ----- | ------ | ---- |
| 1   | 77.69 | 126.40 | 7.24 |
| 2   | 77.56 | 126.12 | 7.20 |
| 3   | 77.53 | 126.24 | 7.11 |
| 4   | 77.28 | 125.90 | 7.16 |
| 5   | 77.42 | 126.05 | 7.19 |
| AVG | 77.50 | 126.14 | 7.18 |
|


https://reviews.llvm.org/D48899





More information about the llvm-commits mailing list