[PATCH] D37582: CodeGen: Remove pipeline dependencies on StackProtector; NFC

[Stephen Crane via Phabricator via llvm-commits]

rinon added a comment.

Thanks @MatzeB. Yes, I believe GlobalISel wasn't enabled yet when I last touched this patch. I'd be happy to take a look at those failures now, if you want.



================
Comment at: include/llvm/CodeGen/StackProtector.h:41
   /// vulnerable stack allocations are located close the stack protector.
   enum SSPLayoutKind {
     SSPLK_None,       ///< Did not trigger a stack protector.  No effect on data
----------------
thegameg wrote:
> This is now duplicated in `MachineFrameInfo.h`.
Good point, this should probably use the MFI enum.


================
Comment at: include/llvm/CodeGen/StackProtector.h:71
   /// AllocaInst triggers a stack protector.
   SSPLayoutMap Layout;
 
----------------
thegameg wrote:
> Is this still needed now that all the info is in MFI?
Yes. `initializeStackProtectorMap` uses `getSSPLayout` which uses this map. It can be dropped when we are done with the analysis pass now, though.


Repository:
  rL LLVM

https://reviews.llvm.org/D37582