[PATCH] D49124: [Tablegen] Optimize isSubsetOf() in AsmMatcherEmitter.cpp

David Greene via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 12 10:14:42 PDT 2018


greened added a comment.

LGTM, with one not-critical comment about comment placement.



================
Comment at: utils/TableGen/AsmMatcherEmitter.cpp:278
+    SmallPtrSet<const ClassInfo *, 16> Visited;
     // ... or if any of its super classes are a subset of RHS.
+    while (!Worklist.empty()) {
----------------
Perhaps this comment should go about the declarations immediate before it.


Repository:
  rL LLVM

https://reviews.llvm.org/D49124





More information about the llvm-commits mailing list