[PATCH] D49247: [NFC][X86][AArch64] Add tests for the 'check for [no] signed truncation' pattern

[Sanjay Patel via Phabricator via llvm-commits]

spatel accepted this revision.
spatel added a comment.
This revision is now accepted and ready to land.

LGTM - one possible improvement inline.



================
Comment at: test/CodeGen/X86/lack-of-signed-truncation-check.ll:382-384
+; X86-NEXT:    .cfi_def_cfa_offset 8
+; X86-NEXT:    .cfi_offset %esi, -8
+; X86-NEXT:    movl {{[0-9]+}}(%esp), %eax
----------------
Add 'nounwind' attr to avoid the .cfi noise? Should probably do that for all x86 for consistency.


Repository:
  rL LLVM

https://reviews.llvm.org/D49247