[PATCH] D47904: Support option -plugin-opt=dwo_dir=

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: test/ELF/lto/thinlto-debug-fission.ll:3
+
+; RUN: pwd
+; RUN: opt  %s -o %t1.o
----------------
Remove.


================
Comment at: test/ELF/lto/thinlto-debug-fission.ll:4
+; RUN: pwd
+; RUN: opt  %s -o %t1.o
+
----------------
Double space characters.


================
Comment at: test/ELF/lto/thinlto-debug-fission.ll:7
+; Test to ensure that --plugin-opt=dwo_dir=$DIR creates .dwo files under $DIR
+; RUN: ld.lld --plugin-opt=dwo_dir=%T/dwo -shared %t1.o -o %t2
+; RUN: llvm-readobj -h %T/dwo/0.dwo | FileCheck %s
----------------
If the specified directory doesn't exist, does --plug-opt=dwo_dir creates a new directory?


================
Comment at: test/ELF/lto/thinlto-debug-fission.ll:7
+; Test to ensure that --plugin-opt=dwo_dir=$DIR creates .dwo files under $DIR
+; RUN: ld.lld --plugin-opt=dwo_dir=%T/dwo -shared %t1.o -o %t2
+; RUN: llvm-readobj -h %T/dwo/0.dwo | FileCheck %s
----------------
ruiu wrote:
> If the specified directory doesn't exist, does --plug-opt=dwo_dir creates a new directory?
`-o /dev/null` is preferred if you don't need an output file.


https://reviews.llvm.org/D47904