[PATCH] D37582: CodeGen: Remove pipeline dependencies on StackProtector; NFC

[Francis Visoiu Mistrih via Phabricator via llvm-commits]

thegameg added a comment.

Thanks @rinon for this. Are you still interested in committing this? I would like to get this in to fix some X86 machine verifier issues.
Some comments below, other than that it LGTM, I can commit this for you after that.



================
Comment at: include/llvm/CodeGen/StackProtector.h:41
   /// vulnerable stack allocations are located close the stack protector.
   enum SSPLayoutKind {
     SSPLK_None,       ///< Did not trigger a stack protector.  No effect on data
----------------
This is now duplicated in `MachineFrameInfo.h`.


================
Comment at: include/llvm/CodeGen/StackProtector.h:71
   /// AllocaInst triggers a stack protector.
   SSPLayoutMap Layout;
 
----------------
Is this still needed now that all the info is in MFI?


Repository:
  rL LLVM

https://reviews.llvm.org/D37582