[PATCH] D44579: [asan] Clean up some confusing code in `test/asan/TestCases/Darwin/segv_read_write.c`

[Dan Liew via Phabricator via llvm-commits]

delcypher added a comment.

In https://reviews.llvm.org/D44579#1044875, @eugenis wrote:

> The comment makes sense to me. Writes are instrumented with reads from shadow in ASan. Therefore a write to addr in shadow will result in a read from shadow(addr), which is located in the mprotect-ed shadow gap, and will be reported as a read SEGV, not a write SEGV.
>
> mmap() argument change looks fine.


Thanks for that explanation. That makes more sense now. I'm going to integrate your explanation into the comment and merge.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D44579