[PATCH] D49177: [CMake] Remove unnecesary list of source files for Xray unit tests.

[Dan Liew via Phabricator via llvm-commits]

delcypher added a comment.

In https://reviews.llvm.org/D49177#1159416, @dberris wrote:

> LGTM -- @nglevin was working on getting the XRay unit tests at least build and run but got interrupted.
>
> The original reason for doing this was to ensure that when any of the implementation files changed, that the unit tests would be built. As you've learned this only made sense for platforms where the tests are built and run.


In general, in CMake,  the target for running a test is made to be dependent on the unit test being executed.. In turn the unit test is linked against the libraries it uses. If the source files for a library change that should trigger the library to be rebuilt. At the minimum this will cause the unit test to be relinked. If the unit test also depends on header files that have changed that should cause the unit test to be recompiled too.

Why is that not sufficient for us?


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D49177