[PATCH] D49205: [InstCombine] Fold x & (-1 >> y) != x to x u> (-1 >> y)

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 12 06:41:26 PDT 2018


lebedev.ri added a comment.

In https://reviews.llvm.org/D49205#1160003, @spatel wrote:

> LGTM


Thank you for the review.

In https://reviews.llvm.org/D49205#1160003, @spatel wrote:

> - unless you have questions/concerns, I think it's fine if you want to continue enhancing this fold without pre-commit review. You've already done the hard part of writing the proofs and regression tests. :)


The other 4(?) patterns here will be non-commutative, so i'm not sure how those will go yet..


Repository:
  rL LLVM

https://reviews.llvm.org/D49205





More information about the llvm-commits mailing list