[PATCH] D49159: [windows] Fix out-of-memory failure in some of the tests
Jim Ingham via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jul 11 16:18:35 PDT 2018
jingham added a comment.
The comment for ReadMemory (in Process.h) says it returns 0 on error, but DoReadMemory doesn't say that. Also the comments are out of date and don't mention the error parameter. Could you fix that so newer plugin authors will know to do the right thing too?
Repository:
rL LLVM
https://reviews.llvm.org/D49159
More information about the llvm-commits
mailing list