[PATCH] D49037: AMDGPU: Refactor Subtarget classes

[Tom Stellard via Phabricator via llvm-commits]

tstellar marked 5 inline comments as done.
tstellar added inline comments.


================
Comment at: lib/Target/AMDGPU/AMDGPUSubtarget.h:230
     // Gap for R600 generations, so we can do comparisons between
-    // AMDGPUSubtarget and r600Subtarget.
+    // GCNSubtarget and r600Subtarget.
     SOUTHERN_ISLANDS = 4,
----------------
jvesely wrote:
> Just out of curiosity what's the benefit of having this enum split between GCNSUbtarget and R600Subtarget, vs merging it in AMDGPUSubtarget?
There is no benefit, so I've merged the enums back together.


Repository:
  rL LLVM

https://reviews.llvm.org/D49037