[PATCH] D49126: [PredicateInfo] Use custom mangling to support ssa_copy with unnamed types.

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 11 11:47:22 PDT 2018


efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.

LGTM with one nit.  I'm not really happy we're creating temporarily invalid IR, but it shouldn't cause any problems, and I don't see a better solution here.



================
Comment at: lib/Transforms/Utils/PredicateInfo.cpp:729
+  // internally and we have to remove the asserting value handles first.
+  SmallPtrSet<Function *, 20> FunctionPtrs;
+  for (auto &F : CreatedDeclarations)
----------------
Can you just use a SmallVector here?


https://reviews.llvm.org/D49126





More information about the llvm-commits mailing list