[PATCH] D49196: [llvm-mca][BtVer2] teach how to identify false dependencies on partially written registers.
Simon Pilgrim via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jul 11 11:12:59 PDT 2018
RKSimon added inline comments.
================
Comment at: tools/llvm-mca/RegisterFile.cpp:155
+ RegisterRenamingInfo &RRI = RegisterMappings[RegID].second;
+ const unsigned RenameAs = RRI.RenameAs;
+
----------------
Use RRI.RenameAs direct and make RRI const?
================
Comment at: tools/llvm-mca/RegisterFile.cpp:331
+ const RegisterRenamingInfo &RRI = RM.second;
+ const std::pair<unsigned, unsigned> &IndexPlusCost = RRI.IndexPlusCost;
dbgs() << MRI.getName(I) << ", " << I << ", PRF=" << IndexPlusCost.first
----------------
Is this worth it? Just use RRI.IndexPlusCost directly below?
https://reviews.llvm.org/D49196
More information about the llvm-commits
mailing list