[llvm] r336818 - [X86] Fix MayLoad/HasSideEffect flag for (V)MOVLPSrm instructions.
Andrea Di Biagio via llvm-commits
llvm-commits at lists.llvm.org
Wed Jul 11 08:27:51 PDT 2018
Author: adibiagio
Date: Wed Jul 11 08:27:50 2018
New Revision: 336818
URL: http://llvm.org/viewvc/llvm-project?rev=336818&view=rev
Log:
[X86] Fix MayLoad/HasSideEffect flag for (V)MOVLPSrm instructions.
Before revision 336728, the "mayLoad" flag for instruction (V)MOVLPSrm was
inferred directly from the "default" pattern associated with the instruction
definition.
r336728 removed special node X86Movlps, and all the patterns associated to it.
Now instruction (V)MOVLPSrm doesn't have a pattern associated to it, and the
'mayLoad/hasSideEffects' flags are left unset.
When the instruction info is emitted by tablegen, method
CodeGenDAGPatterns::InferInstructionFlags() sees that (V)MOVLPSrm doesn't have a
pattern, and flags are undefined. So, it conservatively sets the
"hasSideEffects" flag for it.
As a consequence, we were losing the 'mayLoad' flag, and we were gaining a
'hasSideEffect' flag in its place.
This patch fixes the issue (originally reported by Michael Holmen).
The mca tests show the differences in the instruction info flags. Instructions
that were affected by this problem were: MOVLPSrm/VMOVLPSrm/VMOVLPSZ128rm.
Differential Revision: https://reviews.llvm.org/D49182
Modified:
llvm/trunk/lib/Target/X86/X86InstrAVX512.td
llvm/trunk/lib/Target/X86/X86InstrSSE.td
llvm/trunk/test/tools/llvm-mca/X86/Atom/resources-sse1.s
llvm/trunk/test/tools/llvm-mca/X86/Broadwell/resources-avx1.s
llvm/trunk/test/tools/llvm-mca/X86/Broadwell/resources-sse1.s
llvm/trunk/test/tools/llvm-mca/X86/BtVer2/resources-avx1.s
llvm/trunk/test/tools/llvm-mca/X86/BtVer2/resources-sse1.s
llvm/trunk/test/tools/llvm-mca/X86/Generic/resources-avx1.s
llvm/trunk/test/tools/llvm-mca/X86/Generic/resources-sse1.s
llvm/trunk/test/tools/llvm-mca/X86/Haswell/resources-avx1.s
llvm/trunk/test/tools/llvm-mca/X86/Haswell/resources-sse1.s
llvm/trunk/test/tools/llvm-mca/X86/SLM/resources-sse1.s
llvm/trunk/test/tools/llvm-mca/X86/SandyBridge/resources-avx1.s
llvm/trunk/test/tools/llvm-mca/X86/SandyBridge/resources-sse1.s
llvm/trunk/test/tools/llvm-mca/X86/SkylakeClient/resources-avx1.s
llvm/trunk/test/tools/llvm-mca/X86/SkylakeClient/resources-sse1.s
llvm/trunk/test/tools/llvm-mca/X86/SkylakeServer/resources-avx1.s
llvm/trunk/test/tools/llvm-mca/X86/SkylakeServer/resources-sse1.s
llvm/trunk/test/tools/llvm-mca/X86/Znver1/resources-avx1.s
llvm/trunk/test/tools/llvm-mca/X86/Znver1/resources-sse1.s
Modified: llvm/trunk/lib/Target/X86/X86InstrAVX512.td
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86InstrAVX512.td?rev=336818&r1=336817&r2=336818&view=diff
==============================================================================
--- llvm/trunk/lib/Target/X86/X86InstrAVX512.td (original)
+++ llvm/trunk/lib/Target/X86/X86InstrAVX512.td Wed Jul 11 08:27:50 2018
@@ -6385,7 +6385,7 @@ def VMOVHLPSZrr : AVX512PSI<0x12, MRMSrc
multiclass avx512_mov_hilo_packed<bits<8> opc, string OpcodeStr,
SDPatternOperator OpNode,
X86VectorVTInfo _> {
- let ExeDomain = _.ExeDomain in
+ let hasSideEffects = 0, mayLoad = 1, ExeDomain = _.ExeDomain in
def rm : AVX512<opc, MRMSrcMem, (outs _.RC:$dst),
(ins _.RC:$src1, f64mem:$src2),
!strconcat(OpcodeStr,
Modified: llvm/trunk/lib/Target/X86/X86InstrSSE.td
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86InstrSSE.td?rev=336818&r1=336817&r2=336818&view=diff
==============================================================================
--- llvm/trunk/lib/Target/X86/X86InstrSSE.td (original)
+++ llvm/trunk/lib/Target/X86/X86InstrSSE.td Wed Jul 11 08:27:50 2018
@@ -630,6 +630,7 @@ let Predicates = [UseSSE1] in {
multiclass sse12_mov_hilo_packed_base<bits<8>opc, SDNode psnode, SDNode pdnode,
string base_opc, string asm_opr> {
+ let hasSideEffects = 0, mayLoad = 1 in
def PSrm : PI<opc, MRMSrcMem,
(outs VR128:$dst), (ins VR128:$src1, f64mem:$src2),
!strconcat(base_opc, "s", asm_opr),
@@ -639,6 +640,7 @@ multiclass sse12_mov_hilo_packed_base<bi
SSEPackedSingle>, PS,
Sched<[SchedWriteFShuffle.XMM.Folded, ReadAfterLd]>;
+ let hasSideEffects = 0, mayLoad = 1 in
def PDrm : PI<opc, MRMSrcMem,
(outs VR128:$dst), (ins VR128:$src1, f64mem:$src2),
!strconcat(base_opc, "d", asm_opr),
Modified: llvm/trunk/test/tools/llvm-mca/X86/Atom/resources-sse1.s
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-mca/X86/Atom/resources-sse1.s?rev=336818&r1=336817&r2=336818&view=diff
==============================================================================
--- llvm/trunk/test/tools/llvm-mca/X86/Atom/resources-sse1.s (original)
+++ llvm/trunk/test/tools/llvm-mca/X86/Atom/resources-sse1.s Wed Jul 11 08:27:50 2018
@@ -248,7 +248,7 @@ xorps (%rax), %xmm2
# CHECK-NEXT: 1 1 1.00 * movhps %xmm0, (%rax)
# CHECK-NEXT: 1 1 1.00 * movhps (%rax), %xmm2
# CHECK-NEXT: 1 1 1.00 * movlps %xmm0, (%rax)
-# CHECK-NEXT: 1 1 1.00 U movlps (%rax), %xmm2
+# CHECK-NEXT: 1 1 1.00 * movlps (%rax), %xmm2
# CHECK-NEXT: 1 3 3.00 movmskps %xmm0, %ecx
# CHECK-NEXT: 1 1 1.00 * movntps %xmm0, (%rax)
# CHECK-NEXT: 1 1 1.00 * * U movntq %mm0, (%rax)
Modified: llvm/trunk/test/tools/llvm-mca/X86/Broadwell/resources-avx1.s
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-mca/X86/Broadwell/resources-avx1.s?rev=336818&r1=336817&r2=336818&view=diff
==============================================================================
--- llvm/trunk/test/tools/llvm-mca/X86/Broadwell/resources-avx1.s (original)
+++ llvm/trunk/test/tools/llvm-mca/X86/Broadwell/resources-avx1.s Wed Jul 11 08:27:50 2018
@@ -1281,7 +1281,7 @@ vzeroupper
# CHECK-NEXT: 2 1 1.00 * vmovlpd %xmm0, (%rax)
# CHECK-NEXT: 2 6 1.00 * vmovlpd (%rax), %xmm1, %xmm2
# CHECK-NEXT: 2 1 1.00 * vmovlps %xmm0, (%rax)
-# CHECK-NEXT: 2 6 1.00 U vmovlps (%rax), %xmm1, %xmm2
+# CHECK-NEXT: 2 6 1.00 * vmovlps (%rax), %xmm1, %xmm2
# CHECK-NEXT: 1 3 1.00 vmovmskpd %xmm0, %ecx
# CHECK-NEXT: 1 3 1.00 vmovmskpd %ymm0, %ecx
# CHECK-NEXT: 1 3 1.00 vmovmskps %xmm0, %ecx
Modified: llvm/trunk/test/tools/llvm-mca/X86/Broadwell/resources-sse1.s
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-mca/X86/Broadwell/resources-sse1.s?rev=336818&r1=336817&r2=336818&view=diff
==============================================================================
--- llvm/trunk/test/tools/llvm-mca/X86/Broadwell/resources-sse1.s (original)
+++ llvm/trunk/test/tools/llvm-mca/X86/Broadwell/resources-sse1.s Wed Jul 11 08:27:50 2018
@@ -248,7 +248,7 @@ xorps (%rax), %xmm2
# CHECK-NEXT: 2 1 1.00 * movhps %xmm0, (%rax)
# CHECK-NEXT: 2 6 1.00 * movhps (%rax), %xmm2
# CHECK-NEXT: 2 1 1.00 * movlps %xmm0, (%rax)
-# CHECK-NEXT: 2 6 1.00 U movlps (%rax), %xmm2
+# CHECK-NEXT: 2 6 1.00 * movlps (%rax), %xmm2
# CHECK-NEXT: 1 3 1.00 movmskps %xmm0, %ecx
# CHECK-NEXT: 2 1 1.00 * movntps %xmm0, (%rax)
# CHECK-NEXT: 2 1 1.00 * * U movntq %mm0, (%rax)
Modified: llvm/trunk/test/tools/llvm-mca/X86/BtVer2/resources-avx1.s
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-mca/X86/BtVer2/resources-avx1.s?rev=336818&r1=336817&r2=336818&view=diff
==============================================================================
--- llvm/trunk/test/tools/llvm-mca/X86/BtVer2/resources-avx1.s (original)
+++ llvm/trunk/test/tools/llvm-mca/X86/BtVer2/resources-avx1.s Wed Jul 11 08:27:50 2018
@@ -1281,7 +1281,7 @@ vzeroupper
# CHECK-NEXT: 1 2 1.00 * vmovlpd %xmm0, (%rax)
# CHECK-NEXT: 1 6 1.00 * vmovlpd (%rax), %xmm1, %xmm2
# CHECK-NEXT: 1 2 1.00 * vmovlps %xmm0, (%rax)
-# CHECK-NEXT: 1 6 1.00 U vmovlps (%rax), %xmm1, %xmm2
+# CHECK-NEXT: 1 6 1.00 * vmovlps (%rax), %xmm1, %xmm2
# CHECK-NEXT: 1 3 1.00 vmovmskpd %xmm0, %ecx
# CHECK-NEXT: 1 3 1.00 vmovmskpd %ymm0, %ecx
# CHECK-NEXT: 1 3 1.00 vmovmskps %xmm0, %ecx
Modified: llvm/trunk/test/tools/llvm-mca/X86/BtVer2/resources-sse1.s
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-mca/X86/BtVer2/resources-sse1.s?rev=336818&r1=336817&r2=336818&view=diff
==============================================================================
--- llvm/trunk/test/tools/llvm-mca/X86/BtVer2/resources-sse1.s (original)
+++ llvm/trunk/test/tools/llvm-mca/X86/BtVer2/resources-sse1.s Wed Jul 11 08:27:50 2018
@@ -248,7 +248,7 @@ xorps (%rax), %xmm2
# CHECK-NEXT: 1 2 1.00 * movhps %xmm0, (%rax)
# CHECK-NEXT: 1 6 1.00 * movhps (%rax), %xmm2
# CHECK-NEXT: 1 2 1.00 * movlps %xmm0, (%rax)
-# CHECK-NEXT: 1 6 1.00 U movlps (%rax), %xmm2
+# CHECK-NEXT: 1 6 1.00 * movlps (%rax), %xmm2
# CHECK-NEXT: 1 3 1.00 movmskps %xmm0, %ecx
# CHECK-NEXT: 1 3 1.00 * movntps %xmm0, (%rax)
# CHECK-NEXT: 1 2 1.00 * * U movntq %mm0, (%rax)
Modified: llvm/trunk/test/tools/llvm-mca/X86/Generic/resources-avx1.s
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-mca/X86/Generic/resources-avx1.s?rev=336818&r1=336817&r2=336818&view=diff
==============================================================================
--- llvm/trunk/test/tools/llvm-mca/X86/Generic/resources-avx1.s (original)
+++ llvm/trunk/test/tools/llvm-mca/X86/Generic/resources-avx1.s Wed Jul 11 08:27:50 2018
@@ -1281,7 +1281,7 @@ vzeroupper
# CHECK-NEXT: 1 1 1.00 * vmovlpd %xmm0, (%rax)
# CHECK-NEXT: 2 7 1.00 * vmovlpd (%rax), %xmm1, %xmm2
# CHECK-NEXT: 1 1 1.00 * vmovlps %xmm0, (%rax)
-# CHECK-NEXT: 2 7 1.00 U vmovlps (%rax), %xmm1, %xmm2
+# CHECK-NEXT: 2 7 1.00 * vmovlps (%rax), %xmm1, %xmm2
# CHECK-NEXT: 1 2 1.00 vmovmskpd %xmm0, %ecx
# CHECK-NEXT: 1 2 1.00 vmovmskpd %ymm0, %ecx
# CHECK-NEXT: 1 2 1.00 vmovmskps %xmm0, %ecx
Modified: llvm/trunk/test/tools/llvm-mca/X86/Generic/resources-sse1.s
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-mca/X86/Generic/resources-sse1.s?rev=336818&r1=336817&r2=336818&view=diff
==============================================================================
--- llvm/trunk/test/tools/llvm-mca/X86/Generic/resources-sse1.s (original)
+++ llvm/trunk/test/tools/llvm-mca/X86/Generic/resources-sse1.s Wed Jul 11 08:27:50 2018
@@ -248,7 +248,7 @@ xorps (%rax), %xmm2
# CHECK-NEXT: 1 1 1.00 * movhps %xmm0, (%rax)
# CHECK-NEXT: 2 7 1.00 * movhps (%rax), %xmm2
# CHECK-NEXT: 1 1 1.00 * movlps %xmm0, (%rax)
-# CHECK-NEXT: 2 7 1.00 U movlps (%rax), %xmm2
+# CHECK-NEXT: 2 7 1.00 * movlps (%rax), %xmm2
# CHECK-NEXT: 1 2 1.00 movmskps %xmm0, %ecx
# CHECK-NEXT: 1 1 1.00 * movntps %xmm0, (%rax)
# CHECK-NEXT: 1 1 1.00 * * U movntq %mm0, (%rax)
Modified: llvm/trunk/test/tools/llvm-mca/X86/Haswell/resources-avx1.s
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-mca/X86/Haswell/resources-avx1.s?rev=336818&r1=336817&r2=336818&view=diff
==============================================================================
--- llvm/trunk/test/tools/llvm-mca/X86/Haswell/resources-avx1.s (original)
+++ llvm/trunk/test/tools/llvm-mca/X86/Haswell/resources-avx1.s Wed Jul 11 08:27:50 2018
@@ -1281,7 +1281,7 @@ vzeroupper
# CHECK-NEXT: 2 1 1.00 * vmovlpd %xmm0, (%rax)
# CHECK-NEXT: 2 6 1.00 * vmovlpd (%rax), %xmm1, %xmm2
# CHECK-NEXT: 2 1 1.00 * vmovlps %xmm0, (%rax)
-# CHECK-NEXT: 2 6 1.00 U vmovlps (%rax), %xmm1, %xmm2
+# CHECK-NEXT: 2 6 1.00 * vmovlps (%rax), %xmm1, %xmm2
# CHECK-NEXT: 1 3 1.00 vmovmskpd %xmm0, %ecx
# CHECK-NEXT: 1 3 1.00 vmovmskpd %ymm0, %ecx
# CHECK-NEXT: 1 3 1.00 vmovmskps %xmm0, %ecx
Modified: llvm/trunk/test/tools/llvm-mca/X86/Haswell/resources-sse1.s
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-mca/X86/Haswell/resources-sse1.s?rev=336818&r1=336817&r2=336818&view=diff
==============================================================================
--- llvm/trunk/test/tools/llvm-mca/X86/Haswell/resources-sse1.s (original)
+++ llvm/trunk/test/tools/llvm-mca/X86/Haswell/resources-sse1.s Wed Jul 11 08:27:50 2018
@@ -248,7 +248,7 @@ xorps (%rax), %xmm2
# CHECK-NEXT: 2 1 1.00 * movhps %xmm0, (%rax)
# CHECK-NEXT: 2 6 1.00 * movhps (%rax), %xmm2
# CHECK-NEXT: 2 1 1.00 * movlps %xmm0, (%rax)
-# CHECK-NEXT: 2 6 1.00 U movlps (%rax), %xmm2
+# CHECK-NEXT: 2 6 1.00 * movlps (%rax), %xmm2
# CHECK-NEXT: 1 3 1.00 movmskps %xmm0, %ecx
# CHECK-NEXT: 2 1 1.00 * movntps %xmm0, (%rax)
# CHECK-NEXT: 2 1 1.00 * * U movntq %mm0, (%rax)
Modified: llvm/trunk/test/tools/llvm-mca/X86/SLM/resources-sse1.s
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-mca/X86/SLM/resources-sse1.s?rev=336818&r1=336817&r2=336818&view=diff
==============================================================================
--- llvm/trunk/test/tools/llvm-mca/X86/SLM/resources-sse1.s (original)
+++ llvm/trunk/test/tools/llvm-mca/X86/SLM/resources-sse1.s Wed Jul 11 08:27:50 2018
@@ -248,7 +248,7 @@ xorps (%rax), %xmm2
# CHECK-NEXT: 1 1 1.00 * movhps %xmm0, (%rax)
# CHECK-NEXT: 1 4 1.00 * movhps (%rax), %xmm2
# CHECK-NEXT: 1 1 1.00 * movlps %xmm0, (%rax)
-# CHECK-NEXT: 1 4 1.00 U movlps (%rax), %xmm2
+# CHECK-NEXT: 1 4 1.00 * movlps (%rax), %xmm2
# CHECK-NEXT: 1 4 1.00 movmskps %xmm0, %ecx
# CHECK-NEXT: 1 1 1.00 * movntps %xmm0, (%rax)
# CHECK-NEXT: 1 1 1.00 * * U movntq %mm0, (%rax)
Modified: llvm/trunk/test/tools/llvm-mca/X86/SandyBridge/resources-avx1.s
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-mca/X86/SandyBridge/resources-avx1.s?rev=336818&r1=336817&r2=336818&view=diff
==============================================================================
--- llvm/trunk/test/tools/llvm-mca/X86/SandyBridge/resources-avx1.s (original)
+++ llvm/trunk/test/tools/llvm-mca/X86/SandyBridge/resources-avx1.s Wed Jul 11 08:27:50 2018
@@ -1281,7 +1281,7 @@ vzeroupper
# CHECK-NEXT: 1 1 1.00 * vmovlpd %xmm0, (%rax)
# CHECK-NEXT: 2 7 1.00 * vmovlpd (%rax), %xmm1, %xmm2
# CHECK-NEXT: 1 1 1.00 * vmovlps %xmm0, (%rax)
-# CHECK-NEXT: 2 7 1.00 U vmovlps (%rax), %xmm1, %xmm2
+# CHECK-NEXT: 2 7 1.00 * vmovlps (%rax), %xmm1, %xmm2
# CHECK-NEXT: 1 2 1.00 vmovmskpd %xmm0, %ecx
# CHECK-NEXT: 1 2 1.00 vmovmskpd %ymm0, %ecx
# CHECK-NEXT: 1 2 1.00 vmovmskps %xmm0, %ecx
Modified: llvm/trunk/test/tools/llvm-mca/X86/SandyBridge/resources-sse1.s
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-mca/X86/SandyBridge/resources-sse1.s?rev=336818&r1=336817&r2=336818&view=diff
==============================================================================
--- llvm/trunk/test/tools/llvm-mca/X86/SandyBridge/resources-sse1.s (original)
+++ llvm/trunk/test/tools/llvm-mca/X86/SandyBridge/resources-sse1.s Wed Jul 11 08:27:50 2018
@@ -248,7 +248,7 @@ xorps (%rax), %xmm2
# CHECK-NEXT: 1 1 1.00 * movhps %xmm0, (%rax)
# CHECK-NEXT: 2 7 1.00 * movhps (%rax), %xmm2
# CHECK-NEXT: 1 1 1.00 * movlps %xmm0, (%rax)
-# CHECK-NEXT: 2 7 1.00 U movlps (%rax), %xmm2
+# CHECK-NEXT: 2 7 1.00 * movlps (%rax), %xmm2
# CHECK-NEXT: 1 2 1.00 movmskps %xmm0, %ecx
# CHECK-NEXT: 1 1 1.00 * movntps %xmm0, (%rax)
# CHECK-NEXT: 1 1 1.00 * * U movntq %mm0, (%rax)
Modified: llvm/trunk/test/tools/llvm-mca/X86/SkylakeClient/resources-avx1.s
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-mca/X86/SkylakeClient/resources-avx1.s?rev=336818&r1=336817&r2=336818&view=diff
==============================================================================
--- llvm/trunk/test/tools/llvm-mca/X86/SkylakeClient/resources-avx1.s (original)
+++ llvm/trunk/test/tools/llvm-mca/X86/SkylakeClient/resources-avx1.s Wed Jul 11 08:27:50 2018
@@ -1281,7 +1281,7 @@ vzeroupper
# CHECK-NEXT: 2 1 1.00 * vmovlpd %xmm0, (%rax)
# CHECK-NEXT: 2 6 1.00 * vmovlpd (%rax), %xmm1, %xmm2
# CHECK-NEXT: 2 1 1.00 * vmovlps %xmm0, (%rax)
-# CHECK-NEXT: 2 6 1.00 U vmovlps (%rax), %xmm1, %xmm2
+# CHECK-NEXT: 2 6 1.00 * vmovlps (%rax), %xmm1, %xmm2
# CHECK-NEXT: 1 2 1.00 vmovmskpd %xmm0, %ecx
# CHECK-NEXT: 1 2 1.00 vmovmskpd %ymm0, %ecx
# CHECK-NEXT: 1 2 1.00 vmovmskps %xmm0, %ecx
Modified: llvm/trunk/test/tools/llvm-mca/X86/SkylakeClient/resources-sse1.s
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-mca/X86/SkylakeClient/resources-sse1.s?rev=336818&r1=336817&r2=336818&view=diff
==============================================================================
--- llvm/trunk/test/tools/llvm-mca/X86/SkylakeClient/resources-sse1.s (original)
+++ llvm/trunk/test/tools/llvm-mca/X86/SkylakeClient/resources-sse1.s Wed Jul 11 08:27:50 2018
@@ -248,7 +248,7 @@ xorps (%rax), %xmm2
# CHECK-NEXT: 2 1 1.00 * movhps %xmm0, (%rax)
# CHECK-NEXT: 2 6 1.00 * movhps (%rax), %xmm2
# CHECK-NEXT: 2 1 1.00 * movlps %xmm0, (%rax)
-# CHECK-NEXT: 2 6 1.00 U movlps (%rax), %xmm2
+# CHECK-NEXT: 2 6 1.00 * movlps (%rax), %xmm2
# CHECK-NEXT: 1 2 1.00 movmskps %xmm0, %ecx
# CHECK-NEXT: 2 1 1.00 * movntps %xmm0, (%rax)
# CHECK-NEXT: 2 1 1.00 * * U movntq %mm0, (%rax)
Modified: llvm/trunk/test/tools/llvm-mca/X86/SkylakeServer/resources-avx1.s
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-mca/X86/SkylakeServer/resources-avx1.s?rev=336818&r1=336817&r2=336818&view=diff
==============================================================================
--- llvm/trunk/test/tools/llvm-mca/X86/SkylakeServer/resources-avx1.s (original)
+++ llvm/trunk/test/tools/llvm-mca/X86/SkylakeServer/resources-avx1.s Wed Jul 11 08:27:50 2018
@@ -1281,7 +1281,7 @@ vzeroupper
# CHECK-NEXT: 2 1 1.00 * vmovlpd %xmm0, (%rax)
# CHECK-NEXT: 2 6 1.00 * vmovlpd (%rax), %xmm1, %xmm2
# CHECK-NEXT: 2 1 1.00 * vmovlps %xmm0, (%rax)
-# CHECK-NEXT: 2 6 1.00 U vmovlps (%rax), %xmm1, %xmm2
+# CHECK-NEXT: 2 6 1.00 * vmovlps (%rax), %xmm1, %xmm2
# CHECK-NEXT: 1 2 1.00 vmovmskpd %xmm0, %ecx
# CHECK-NEXT: 1 2 1.00 vmovmskpd %ymm0, %ecx
# CHECK-NEXT: 1 2 1.00 vmovmskps %xmm0, %ecx
Modified: llvm/trunk/test/tools/llvm-mca/X86/SkylakeServer/resources-sse1.s
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-mca/X86/SkylakeServer/resources-sse1.s?rev=336818&r1=336817&r2=336818&view=diff
==============================================================================
--- llvm/trunk/test/tools/llvm-mca/X86/SkylakeServer/resources-sse1.s (original)
+++ llvm/trunk/test/tools/llvm-mca/X86/SkylakeServer/resources-sse1.s Wed Jul 11 08:27:50 2018
@@ -248,7 +248,7 @@ xorps (%rax), %xmm2
# CHECK-NEXT: 2 1 1.00 * movhps %xmm0, (%rax)
# CHECK-NEXT: 2 6 1.00 * movhps (%rax), %xmm2
# CHECK-NEXT: 2 1 1.00 * movlps %xmm0, (%rax)
-# CHECK-NEXT: 2 6 1.00 U movlps (%rax), %xmm2
+# CHECK-NEXT: 2 6 1.00 * movlps (%rax), %xmm2
# CHECK-NEXT: 1 2 1.00 movmskps %xmm0, %ecx
# CHECK-NEXT: 2 1 1.00 * movntps %xmm0, (%rax)
# CHECK-NEXT: 2 1 1.00 * * U movntq %mm0, (%rax)
Modified: llvm/trunk/test/tools/llvm-mca/X86/Znver1/resources-avx1.s
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-mca/X86/Znver1/resources-avx1.s?rev=336818&r1=336817&r2=336818&view=diff
==============================================================================
--- llvm/trunk/test/tools/llvm-mca/X86/Znver1/resources-avx1.s (original)
+++ llvm/trunk/test/tools/llvm-mca/X86/Znver1/resources-avx1.s Wed Jul 11 08:27:50 2018
@@ -1281,7 +1281,7 @@ vzeroupper
# CHECK-NEXT: 1 1 0.50 * vmovlpd %xmm0, (%rax)
# CHECK-NEXT: 1 8 0.50 * vmovlpd (%rax), %xmm1, %xmm2
# CHECK-NEXT: 1 1 0.50 * vmovlps %xmm0, (%rax)
-# CHECK-NEXT: 1 8 0.50 U vmovlps (%rax), %xmm1, %xmm2
+# CHECK-NEXT: 1 8 0.50 * vmovlps (%rax), %xmm1, %xmm2
# CHECK-NEXT: 1 1 1.00 vmovmskpd %xmm0, %ecx
# CHECK-NEXT: 1 1 1.00 vmovmskpd %ymm0, %ecx
# CHECK-NEXT: 1 1 1.00 vmovmskps %xmm0, %ecx
Modified: llvm/trunk/test/tools/llvm-mca/X86/Znver1/resources-sse1.s
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-mca/X86/Znver1/resources-sse1.s?rev=336818&r1=336817&r2=336818&view=diff
==============================================================================
--- llvm/trunk/test/tools/llvm-mca/X86/Znver1/resources-sse1.s (original)
+++ llvm/trunk/test/tools/llvm-mca/X86/Znver1/resources-sse1.s Wed Jul 11 08:27:50 2018
@@ -248,7 +248,7 @@ xorps (%rax), %xmm2
# CHECK-NEXT: 1 1 0.50 * movhps %xmm0, (%rax)
# CHECK-NEXT: 1 8 0.50 * movhps (%rax), %xmm2
# CHECK-NEXT: 1 1 0.50 * movlps %xmm0, (%rax)
-# CHECK-NEXT: 1 8 0.50 U movlps (%rax), %xmm2
+# CHECK-NEXT: 1 8 0.50 * movlps (%rax), %xmm2
# CHECK-NEXT: 1 1 1.00 movmskps %xmm0, %ecx
# CHECK-NEXT: 1 1 0.50 * movntps %xmm0, (%rax)
# CHECK-NEXT: 1 1 0.50 * * U movntq %mm0, (%rax)
More information about the llvm-commits
mailing list