[PATCH] D49049: [LSR] If no Use is interesting, early return.

[Sanjoy Das via Phabricator via llvm-commits]

sanjoy accepted this revision.
sanjoy added a comment.
This revision is now accepted and ready to land.

I'd debug this a bit further, perhaps with some logging statements to figure out what happened (what use did we discard as non-interesting and why?).  But if that looks like too much work then this change as-is is fine too.



================
Comment at: llvm/test/CodeGen/X86/lsr-crash-empty-uses.ll:1
+; RUN: llc --start-before loop-reduce --stop-after loop-reduce %s -o - | FileCheck %s
+target triple = "x86_64-unknown-linux-gnu"
----------------
Can't you run LSR directly using `opt`?


================
Comment at: llvm/test/CodeGen/X86/lsr-crash-empty-uses.ll:39
+
+_ZSt10accumulateIPddET0_T_S2_S1_.exit138:         ; preds = %_ZSt10accumulateIPddET0_T_S2_S1_.exit138.loopexit, %for.body.i136.prol.loopexit
+  br label %for.body119
----------------
Would be nice to clean up these names.  Maybe use `opt -metarenamer`?


https://reviews.llvm.org/D49049