[PATCH] D49174: [AArch64] Remove AArch64TargetLowering::BuildSDIVPow2 override

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 11 04:14:50 PDT 2018


RKSimon created this revision.
RKSimon added reviewers: efriedma, rengolin, javed.absar, t.p.northover, evandro.
Herald added a subscriber: kristof.beyls.

Now that https://reviews.llvm.org/D45806 etc has landed we've greatly improved the generic SDIV by constant handling in DAGCombiner.

While investigating how to support non-uniform vectors for TargetLowering::BuildSDIV (PR36545) it was noticed that removing the AArch64 override and using the generic path appears to improve codegen, but I'd like confirmation from arm specialists.


Repository:
  rL LLVM

https://reviews.llvm.org/D49174

Files:
  lib/Target/AArch64/AArch64ISelLowering.cpp
  lib/Target/AArch64/AArch64ISelLowering.h
  test/CodeGen/AArch64/fast-isel-sdiv.ll
  test/CodeGen/AArch64/sdivpow2.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D49174.154967.patch
Type: text/x-patch
Size: 11446 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180711/d90eac84/attachment.bin>


More information about the llvm-commits mailing list