[PATCH] D49043: [llvm-objdump] Add -demangle (-C) option

[Paul Semel via Phabricator via llvm-commits]

paulsemel added inline comments.


================
Comment at: tools/llvm-objdump/llvm-objdump.cpp:336
+void llvm::warn(StringRef Message) {
+  errs() << ToolName << ": warning: " << Message << ".\n";
+}
----------------
jhenderson wrote:
> paulsemel wrote:
> > jhenderson wrote:
> > > Do you need to do `errs().flush()` like in the other error methods?
> > > 
> > > Also, I'd move this to be before or after the two `error()` functions rather than in between them.
> > I can add `errs().flush()`, but with the `\n`, it should be flushed !
> Actually, I don't think that's the case! See [[ https://stackoverflow.com/a/213977 ]].
hmm alright, sound weird to me, doesn't make really sense.. but thanks for the link 😄 


Repository:
  rL LLVM

https://reviews.llvm.org/D49043