[PATCH] D49116: Setup clang-format as an Arcanist linter

Dean Michael Berris via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 11 00:09:04 PDT 2018


dberris added a comment.

One concern here would be whether this would even work on Windows, and whether it might make more sense to use a more portable scripting language to do it instead (say, Python). I don't use Windows so I'll let someone else who does (and uses Arcanist as well) to chime in as to whether this is going to be a problem.



================
Comment at: .arclint:8
+      "include": [
+        "(\\.(cpp|h)$)"
+      ]
----------------
starsid wrote:
> dberris wrote:
> > dberris wrote:
> > > Should this also include '.cc' files?
> > I don't see the change to support .cc files...
> I think this regex captures all the files we want to see -- `"(\\.(cc|cpp|h)$)"` -- no?
Ah, yes. I was looking at an old version of the diff.


Repository:
  rL LLVM

https://reviews.llvm.org/D49116





More information about the llvm-commits mailing list