[PATCH] D48897: [MemorySSA] Add APIs to move memory accesses between blocks, following CFG changes.

[Alina Sbirlea via Phabricator via llvm-commits]

asbirlea marked 12 inline comments as done.
asbirlea added inline comments.


================
Comment at: include/llvm/Analysis/MemorySSAUpdater.h:203
+  void moveAllAccesses(BasicBlock *From, BasicBlock *To, Instruction *Start,
+                       MemorySSA::InsertionPlace Where);
   MemoryAccess *getPreviousDef(MemoryAccess *);
----------------
george.burgess.iv wrote:
> I'm assuming we have plans to make `Where != End` in future patches? (If so, that's OK; I'm just checking, since it looks like we're only passing in `End` right now)
I don't currently have a use case, so removing. I will add it again if a use case comes up.


================
Comment at: lib/Analysis/MemorySSAUpdater.cpp:456
+
+      while (NextMUD) {
+        MUD = NextMUD;
----------------
george.burgess.iv wrote:
> Is it possible to fold some of the above code into this loop without losing much in the way of clarity? It looks really similar to this loop body to me.
I removed the insertion place so that simplified things. PTAL.


Repository:
  rL LLVM

https://reviews.llvm.org/D48897