[PATCH] D49111: [windows] LLDB shows the wrong values when register read is executed at a frame other than zero

Stella Stamenova via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 10 11:16:58 PDT 2018


stella.stamenova added a comment.

In https://reviews.llvm.org/D49111#1157633, @zturner wrote:

> I think this is a matter of opinion and the code is fine as is personally.
>  If you prefer the implicit cast, feel free to leave it.  This pattern is
>  already pervasive all over LLVM and clang, so you can treat it as a nit
>  (fix it if you agree, leave it if you prefer).


It's a small change and it makes things a little more consistent, so I might as well fix it :). Thanks!


Repository:
  rL LLVM

https://reviews.llvm.org/D49111





More information about the llvm-commits mailing list