[PATCH] D49145: [libc++] Declare noop_coroutine() with _LIBCPP_INLINE_VISIBILITY
Louis Dionne via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jul 10 09:32:42 PDT 2018
ldionne created this revision.
ldionne added a reviewer: EricWF.
Herald added subscribers: llvm-commits, dexonsmith, christof, modocache.
It was defined with the right visibility, but declared without any visibility.
This function was left out of a prior revision that did the same to several
functions in <compare> (r336665) because the compiler I used didn't support
coroutines. This reinforces the need for automated checks -- there might
still be several cases of this throughout the library.
Repository:
rL LLVM
https://reviews.llvm.org/D49145
Files:
libcxx/include/experimental/coroutine
Index: libcxx/include/experimental/coroutine
===================================================================
--- libcxx/include/experimental/coroutine
+++ libcxx/include/experimental/coroutine
@@ -283,6 +283,7 @@
_LIBCPP_CONSTEXPR_AFTER_CXX17 void destroy() const _NOEXCEPT {}
private:
+ _LIBCPP_INLINE_VISIBILITY
friend coroutine_handle<noop_coroutine_promise> noop_coroutine() _NOEXCEPT;
_LIBCPP_INLINE_VISIBILITY coroutine_handle() _NOEXCEPT {
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D49145.154831.patch
Type: text/x-patch
Size: 466 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180710/570ef2b6/attachment.bin>
More information about the llvm-commits
mailing list