[PATCH] D47106: [FileCheck] Make CHECK-DAG non-overlapping

[Joel E. Denny via Phabricator via llvm-commits]

jdenny added a comment.

In https://reviews.llvm.org/D47106#1156353, @probinson wrote:

> Given that you feel so very strongly about it, and that this is a tool that really has absolutely zero exposure outside our own test system, I'm willing to say that erring on the side of extra testing is acceptable here.


Hi Paul.  Thanks very much for your consideration.  I apologize for being difficult.

There are 3 more patches that this patch depends upon:

https://reviews.llvm.org/D47326
https://reviews.llvm.org/D47172
https://reviews.llvm.org/D47171

Those need to be committed at the same time as this one to avoid lots of buildbot failures.  They're large but simple-minded patches: I just blindly added -allow-deprecated-dag-overlap to tests that break after adding this patch.  Given that there are many run lines per test, it's possible that some additions weren't actually necessary, but they don't cause new unexpected failures for me, and our plan was to investigate these tests one by one afterward anyway.  I'm currently pulling, rebasing, and re-running tests locally.  I'll extend those patches for any new failures afterward.

Would you please accept those patches as well?  Combing through every line might be a lot to ask, so you could accept on the condition that I actually did what I said I did, and I'll take responsibility for any problems.

Thanks again.


https://reviews.llvm.org/D47106