[PATCH] D49090: [ThinLTO] Escape module paths when printing

[Chris Jackson via Phabricator via llvm-commits]

chrisjackson updated this revision to Diff 154800.
chrisjackson added a comment.

Followed suggestions to make the test simpler.


https://reviews.llvm.org/D49090

Files:
  lib/IR/AsmWriter.cpp
  test/Assembler/asm-path-writer.ll


Index: test/Assembler/asm-path-writer.ll
===================================================================
--- /dev/null
+++ test/Assembler/asm-path-writer.ll
@@ -0,0 +1,6 @@
+; RUN: llvm-as < %s | llvm-dis | FileCheck %s
+
+; CHECK: ^0 = module: (path: ".\5Cf4folder\5Cabc.o", hash: (0, 0, 0, 0, 0))
+
+^0 = module: (path: ".\5Cf4folder\5Cabc.o", hash: (0, 0, 0, 0, 0))
+^1 = gv: (guid: 15822663052811949562, summaries: (function: (module: ^0, flags: (linkage: external, notEligibleToImport: 0, live: 0, dsoLocal: 0), insts: 2)))
Index: lib/IR/AsmWriter.cpp
===================================================================
--- lib/IR/AsmWriter.cpp
+++ lib/IR/AsmWriter.cpp
@@ -2618,8 +2618,9 @@
   unsigned i = 0;
   for (auto &ModPair : moduleVec) {
     Out << "^" << i++ << " = module: (";
-    Out << "path: \"" << ModPair.first << "\"";
-    Out << ", hash: (";
+    Out << "path: \"";
+    printEscapedString(ModPair.first, Out);
+    Out << "\", hash: (";
     FieldSeparator FS;
     for (auto Hash : ModPair.second)
       Out << FS << Hash;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D49090.154800.patch
Type: text/x-patch
Size: 1057 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180710/b0ea6610/attachment.bin>