[PATCH] D49123: [test cases] add test cases for find more abs pattern
Sanjay Patel via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jul 10 07:14:17 PDT 2018
spatel accepted this revision.
spatel added a comment.
This revision is now accepted and ready to land.
In https://reviews.llvm.org/D49123#1157270, @shchenz wrote:
> @spatel Hi Sanjay, thanks very much for your comment. I have updated the description. For duplicated test case issue, "@abs_canonical_2" and @nabs_canonical_2" is for |x|, but my three case is for |-a|, |a-b| for int and vector. I am not clear you mean which one is duplicated?
Ah, I missed that the icmp in abs_canonical_8() is with the negated value. LGTM.
https://reviews.llvm.org/D49123
More information about the llvm-commits
mailing list