[PATCH] D49043: [llvm-objdump] Add -demangle (-C) option

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.

LGTM, with a few minor points.

You should get @davide to confirm he's happy though before submission, since he previously requested changes.



================
Comment at: test/tools/llvm-objdump/disassemble-demangle.test:45
+
+# WRONG-STYLE: Unsupported demangling style.
+# WRONG-STYLE: _Z3fooi
----------------
I'd add "warning:" to the front of this check. And maybe rename the check "BAD-STYLE".


================
Comment at: tools/llvm-objdump/llvm-objdump.cpp:336
+void llvm::warn(StringRef Message) {
+  errs() << ToolName << ": warning: " << Message << ".\n";
+}
----------------
Do you need to do `errs().flush()` like in the other error methods?

Also, I'd move this to be before or after the two `error()` functions rather than in between them.


Repository:
  rL LLVM

https://reviews.llvm.org/D49043