[PATCH] D49025: [XRay] basic mode PID and TID always fetch

Dean Michael Berris via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 9 17:26:49 PDT 2018


dberris accepted this revision.
dberris added a subscriber: kpw.
dberris added a comment.
This revision is now accepted and ready to land.

LGTM, with one minor comment.

Please let me know if/when it's ready to land, so that either I or @kpw can land it for you.

Thanks!

Cheers



================
Comment at: compiler-rt/include/xray/xray_records.h:99
+  // The ID of process that is currently running
+  uint32_t Pid = 0;
+  
----------------
Minor: Maybe name this `PId` to be consistent with `TId`.


https://reviews.llvm.org/D49025





More information about the llvm-commits mailing list