[PATCH] D49104: [libc++] Declare <compare> operators with the proper visibility attribute

Louis Dionne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 9 15:27:26 PDT 2018


ldionne created this revision.
ldionne added reviewers: EricWF, mclow.lists.
Herald added subscribers: llvm-commits, dexonsmith, christof.

Many operators in <compare> were _defined_ with the proper visibility attribute,
but they were _declared_ without any. This is not a problem until we change the
definition of _LIBCPP_INLINE_VISIBILITY to something that requires the
declaration to be decorated.

I also marked `strong_equality::operator weak_equality()` as
`_LIBCPP_INLINE_VISIBILITY`, since it seems like it had been forgotten.

This came up while trying to get rid of `__attribute__((__always_inline__))`
in favor of `__attribute__((internal_linkage))`.


Repository:
  rL LLVM

https://reviews.llvm.org/D49104

Files:
  libcxx/include/compare

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D49104.154714.patch
Type: text/x-patch
Size: 12302 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180709/9ef1edb2/attachment.bin>


More information about the llvm-commits mailing list