[PATCH] D49095: [COFF] Store a pointer to the parent instead of just the parent name in InputFile

Zachary Turner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 9 12:01:18 PDT 2018


zturner created this revision.
zturner added reviewers: ruiu, inglorion.

I'm trying to make LLD PDBs look more like Microsoft PDBs.  While we can never be perfect, any small amount we can get closer saves a lot of time when debugging and adds confidence that our PDBs are "correct".

Currently I'm trying to create the list of modules in the same order that MSVC creates them.  In order to do that, we need a little bit more info from an object file than just the name of its parent.  So, rather than adding more and more fields to keep track of all this extra information, we can just store a pointer to the parent itself.

Currently there's no functional change here, we're just changing a `StringRef` to an `ArchiveFile*`.  In subsequent patches I'll use this to sort the module list in the same order that `link.exe` does before writing the PDB.


https://reviews.llvm.org/D49095

Files:
  lld/COFF/Driver.cpp
  lld/COFF/Driver.h
  lld/COFF/InputFiles.cpp
  lld/COFF/InputFiles.h
  lld/COFF/MinGW.cpp
  lld/COFF/PDB.cpp
  lld/test/COFF/pdb-comdat.test

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D49095.154667.patch
Type: text/x-patch
Size: 7803 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180709/19aadbb7/attachment-0001.bin>


More information about the llvm-commits mailing list