[PATCH] D49033: [test-suite] Add a decorator for the lack of libstdcxx on the system.

Davide Italiano via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 9 11:12:57 PDT 2018


davide added a comment.

In https://reviews.llvm.org/D49033#1155743, @labath wrote:

> Besides the problems I mention in inline comments, the other issue I have with this patch is that it does things completely different than how we implement the check for libc++, which is an identical problem. (libc++ detection is done by marking all libc++ tests as with a special category, and then deciding in dotest.py (`checkLibcxxSupport`) whether to run the category as a whole).
>
> So, I think this should be reverted and replaced by a solution mirroring the libc++ approach. I'm not saying that one is perfect, but it is in many ways better than this one (e.g., if the default skipping logic gets things wrong, you can override it by manually skipping the corresponding category), and most importantly, it makes things consistent.


OK, I'm going to revert this and work on a better solution today.


https://reviews.llvm.org/D49033





More information about the llvm-commits mailing list