[PATCH] D49035: AMDGPU: Force inlining if LDS global address is used

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: lib/Target/AMDGPU/AMDGPUAlwaysInlinePass.cpp:73
-        !F.hasFnAttribute(IncompatAttr))
-      FuncsToClone.push_back(&F);
-  }
----------------
rampitec wrote:
> Why was it cloned and why is it dropped now?
I have no idea why this was ever cloned. I think I tried to fix that once before, and had some issue which I didn’t encounter this time. It was more inconvenient to maintain the weird behavior now.

This also improves the call related error messages since it refers to the actual name without a number appended


https://reviews.llvm.org/D49035