[llvm] r336570 - [InstCombine] correct test comments; NFC

Sanjay Patel via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 9 10:48:08 PDT 2018


Author: spatel
Date: Mon Jul  9 10:48:08 2018
New Revision: 336570

URL: http://llvm.org/viewvc/llvm-project?rev=336570&view=rev
Log:
[InstCombine] correct test comments; NFC

Modified:
    llvm/trunk/test/Transforms/InstCombine/shuffle_select.ll

Modified: llvm/trunk/test/Transforms/InstCombine/shuffle_select.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/InstCombine/shuffle_select.ll?rev=336570&r1=336569&r2=336570&view=diff
==============================================================================
--- llvm/trunk/test/Transforms/InstCombine/shuffle_select.ll (original)
+++ llvm/trunk/test/Transforms/InstCombine/shuffle_select.ll Mon Jul  9 10:48:08 2018
@@ -1023,7 +1023,7 @@ define <4 x i32> @lshr_2_vars_exact(<4 x
   ret <4 x i32> %t3
 }
 
-; TODO: This could be transformed by using a safe constant.
+; TODO: This would require a new shuffle mask (replace undef with op0 or op1 lane). Otherwise, we have shift-by-undef.
 
 define <4 x i32> @lshr_2_vars_undef_mask_elt(<4 x i32> %v0, <4 x i32> %v1) {
 ; CHECK-LABEL: @lshr_2_vars_undef_mask_elt(
@@ -1038,7 +1038,7 @@ define <4 x i32> @lshr_2_vars_undef_mask
   ret <4 x i32> %t3
 }
 
-; TODO: This could be transformed by using a safe constant.
+; TODO: This would require a new shuffle mask (replace undef with op0 or op1 lane). Otherwise, we have shift-by-undef.
 
 define <4 x i32> @lshr_2_vars_exact_undef_mask_elt(<4 x i32> %v0, <4 x i32> %v1) {
 ; CHECK-LABEL: @lshr_2_vars_exact_undef_mask_elt(




More information about the llvm-commits mailing list